Skip to content

Remove "unknown" status and add "failed" and "unreachable" statuses#2630

Merged
martinsander00 merged 1 commit intomainfrom
ms/2622
Jan 20, 2026
Merged

Remove "unknown" status and add "failed" and "unreachable" statuses#2630
martinsander00 merged 1 commit intomainfrom
ms/2622

Conversation

@martinsander00
Copy link
Contributor

@martinsander00 martinsander00 commented Jan 14, 2026 •
edited
Loading

Resolves: #2622

Summary of Changes

  • Removed unknown status
  • Renamed status labels to be more descriptive:
    • pending → Pending BGP Session
    • initializing → Initializing BGP Session
    • down → BGP Session Down
    • up → BGP Session Up
  • Added BGP Session Failed (TCP connected but BGP handshake timed out after 5 seconds)
  • Added Network Unreachable (TCP connection failed, likely firewall issue)

Testing Verification

  • Fixed existing tests
  • Added new tests

@martinsander00
Copy link
Contributor Author

martinsander00 commented Jan 14, 2026 •
edited
Loading

I believe there is no way to know if a link is unreachable due to a firewall issue specifically. However, what I did is infer this by checking whether the TCP connection was ever established before the timeout. The BGP plugin tracks two flags:
tcpConnected - set to true when GetCapabilities() is called (which only happens after TCP handshake succeeds)
currentlyEstablished - set to true when the BGP session is fully established
If the 5-second timeout fires and:
tcpConnected == false → we emit unreachable (TCP never connected, likely firewall/network issue)
tcpConnected == true but currentlyEstablished == false → we emit failed (TCP worked but BGP handshake didn't complete)

@martinsander00 martinsander00 force-pushed the ms/2622 branch 5 times, most recently from 85d7113 to 7c02d22 Compare January 15, 2026 18:37
packethog
packethog requested changes Jan 15, 2026
View reviewed changes
@martinsander00 martinsander00 force-pushed the ms/2622 branch 2 times, most recently from aad9a4c to f3f1fc8 Compare January 15, 2026 20:21
@martinsander00
Remove "unknown" status and add "failed" and "unreachable" statuses
715cfe9 
Resolves: #2622

Changed status name to short version
Jared-dz
Jared-dz reviewed Jan 20, 2026
View reviewed changes
Copy link

@Jared-dz Jared-dz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement to the current state. I am leaving comment without approval to allow time for second reviewer prior to merge.

@martinsander00 martinsander00 merged commit 29a2560 into main Jan 20, 2026
21 checks passed
@martinsander00 martinsander00 deleted the ms/2622 branch January 20, 2026 17:54
thijsvanemmerik pushed a commit that referenced this pull request Feb 3, 2026
@martinsander00 @thijsvanemmerik
Remove "unknown" status and add "failed" and "unreachable" statuses (#…
1e4caf2 
…2630)

Resolves: #2622

## Summary of Changes
* Removed unknown status
* Renamed status labels to be more descriptive:
  * pending → Pending BGP Session
  * initializing → Initializing BGP Session
  * down → BGP Session Down
  * up → BGP Session Up
* Added BGP Session Failed (TCP connected but BGP handshake timed out
after 5 seconds)
* Added Network Unreachable (TCP connection failed, likely firewall
issue)

## Testing Verification
* Fixed existing tests
* Added new tests
thijsvanemmerik pushed a commit that referenced this pull request Feb 3, 2026
@martinsander00 @thijsvanemmerik
Remove "unknown" status and add "failed" and "unreachable" statuses (#…
d88cf40 
…2630)

Resolves: #2622

## Summary of Changes
* Removed unknown status
* Renamed status labels to be more descriptive:
  * pending → Pending BGP Session
  * initializing → Initializing BGP Session
  * down → BGP Session Down
  * up → BGP Session Up
* Added BGP Session Failed (TCP connected but BGP handshake timed out
after 5 seconds)
* Added Network Unreachable (TCP connection failed, likely firewall
issue)


## Testing Verification
* Fixed existing tests
* Added new tests
thijsvanemmerik pushed a commit that referenced this pull request Feb 3, 2026
@martinsander00 @thijsvanemmerik
Remove "unknown" status and add "failed" and "unreachable" statuses (#…
7a6f92a 
…2630)

Resolves: #2622

## Summary of Changes
* Removed unknown status
* Renamed status labels to be more descriptive:
  * pending → Pending BGP Session
  * initializing → Initializing BGP Session
  * down → BGP Session Down
  * up → BGP Session Up
* Added BGP Session Failed (TCP connected but BGP handshake timed out
after 5 seconds)
* Added Network Unreachable (TCP connection failed, likely firewall
issue)


## Testing Verification
* Fixed existing tests
* Added new tests
thijsvanemmerik pushed a commit that referenced this pull request Feb 3, 2026
@martinsander00 @thijsvanemmerik
Remove "unknown" status and add "failed" and "unreachable" statuses (#…
eab98f3 
…2630)

Resolves: #2622

## Summary of Changes
* Removed unknown status
* Renamed status labels to be more descriptive:
  * pending → Pending BGP Session
  * initializing → Initializing BGP Session
  * down → BGP Session Down
  * up → BGP Session Up
* Added BGP Session Failed (TCP connected but BGP handshake timed out
after 5 seconds)
* Added Network Unreachable (TCP connection failed, likely firewall
issue)


## Testing Verification
* Fixed existing tests
* Added new tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jared-dz Jared-dz Jared-dz left review comments

@packethog packethog packethog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change "unknown" label from doublezero status command to something more representative

3 participants

@martinsander00 @packethog @Jared-dz